Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppStream developer id #1815

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

musicinmybrain
Copy link
Contributor

Per https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer, this should have been org.pencil2d instead of pencil2d.org. Technically, the ID can be any string, but the FreeDesktop documentation strongly recommends a reverse-DNS string.

This is a follow-up to #1796.

@J5lx J5lx added this to the v0.6.7 milestone Mar 9, 2024
@J5lx
Copy link
Member

J5lx commented Mar 9, 2024

Well spotted, thanks for fixing that. I just wish those AppStream folks would just pick a naming scheme and stick with it – until just three weeks ago they still recommended a web URL instead. Same with the app id, back when we picked ours all of their examples had mixed-case component ids, now they explicitly recommend lower-case.

But anyway, that’s AppStream’s fault, not yours. Sorry for the little rant and thanks for the PR!

@J5lx J5lx merged commit 46e046f into pencil2d:master Mar 9, 2024
8 checks passed
@musicinmybrain
Copy link
Contributor Author

Thanks for the quick review!

I agree, even as a downstream packager, the recent churn in the AppStream XML format and the way new warnings keep popping up that cause validation failures on previously-valid files has been a pain to keep up with. (AppStream 1.0.2 started warning when <developer/> has no id, so at least we were ahead of the game there.)

I hope things are starting to stablilize now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants