Don't use amerge when exporting a single audio clip #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In versions of ffmpeg < 3.2, passing a single audio track to the amerge filter is not allowed. This simply skips the amerge step when there is only one audio clip.
scribblemaniac
force-pushed
the
legacy-ffmpeg-support
branch
from
eb1b995
to
b0c4aa4
Compare
|
LGTM, thanks for fixing this! I assume it is related to this thread? https://discuss.pencil2d.org/t/nb-cant-export-movies-with-sound/7277/7 |
MrStevns
approved these changes
Jul 18, 2023
Yes that is correct. Thanks for reviewing. I'm going to have to go through and check what versions of ffmpeg we need to support for legacy builds as there appears to be yet another issue with ffmpeg 2.x and it would be nice to use a newer version if we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions of ffmpeg < 3.2, passing a single audio track to the amerge filter is not allowed. This simply skips the amerge step when there is only one audio clip.
This was causing issues for exporting projects with a single audio clip in the Linux AppImage nightly builds where an older version of ffmpeg is currently being bundled.