Add ManyToManyFields on concrete models #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, this doesn't work. self.ixfac_set is a manager object, which is not iterable (one would have to do self.ixfac_set.all() to iterate through it).
In the concrete models, add ManyToManyFields between Network and Facility/IXLan, and InternetExchange and Facility. Intermediate models already exist (NetworkFacility, NetworkIXLan and InternetExchangeFacility respectively) and these are being used as "through" models with Django's many-to-many field. Effectively, this does not really change the schema, but provides forward and reverse managers to go from one of these objects to the next. So for example, one can use ixp.fac_set.all() to list all facilities for an exchange, or fac.ix_set.all() to do the inverse. Note that this change really makes the definitions of the InternetExchangeFacility and InternetExchangeFacilityBase models moot, as they're "through" models with no additional fields, and if they were absent, Django would create the intermediate tables in the database itself. However, avoid not being removed in this change to minimize the amount of changes and risk involved here. Finally, although a more descriptive "facilities" or "networks" would be preferrable in the author's opinion, the new fields are named "<shorthand>_set" (fac_set, ix_set, ixlan_set) to match existing conventions.
|
The CI check here is red herring (in one of the hosts it failed on a |
|
This seems to break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the concrete models, add ManyToManyFields between Network and Facility/IXLan, and InternetExchange and Facility.
Intermediate models already exist (NetworkFacility, NetworkIXLan and InternetExchangeFacility respectively) and these are being used as "through" models with Django's many-to-many field.
Effectively, this does not really change the schema, but provides forward and reverse managers to go from one of these objects to the next. So for example, one can use
ixp.fac_set.all()to list all facilities for an exchange, orfac.ix_set.all()to do the inverse.Note that this change really makes the definitions of the InternetExchangeFacility and InternetExchangeFacilityBase models moot, as they're "through" models with no additional fields, and if they were absent, Django would create the intermediate tables in the database itself. However, avoid not being removed in this change to minimize the amount of changes and risk involved here.
Finally, although a more descriptive "facilities" or "networks" would be preferrable in the author's opinion, the new fields are named
<shorthand>_set(fac_set,ix_set,ixlan_set) to match existing conventions.