Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember focus in IDE panes #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remember focus in IDE panes #252

wants to merge 2 commits into from

Conversation

Spacerat
Copy link
Contributor

@Spacerat Spacerat commented Dec 1, 2015

With this PR, the sidebar manages which elements are automatically focussed when switching to a new pane inside the IDE. Specifically:

  1. When an element in a pane is focussed on, it is recorded as the pane's last focussed element.
  2. When switching back to the pane: if there was a saved element, it is refocussed. (second PR commit)
  3. If there is not, the first element with an 'autofocus' attribute is focussed. (first PR commit)
  4. If there is no autofocus element, the focus is unchanged.

The following gif demonstrates the new behaviour.

autofocus

These changes make it much easier to navigate CloudPebble exclusively with the keyboard in that it's an improvement on the current state of tab-focus (when you switch to a new page and then click TAB, you focus on the navigation), but I'm not 100% sure that it's the best solution. Specifically, it might be better to just autofocus on the first form element every time, and not remember the previously focussed element.

@pebble-heroku pebble-heroku had a problem deploying to cloudpebble-sp-pr-252 January 11, 2016 20:06 Failure
@Katharine
Copy link
Contributor

This branch doesn't merge and also doesn't build, due to outdated requirements.

@pebble-heroku pebble-heroku temporarily deployed to cloudpebble-sp-pr-252 January 12, 2016 01:47 Inactive
@Spacerat
Copy link
Contributor Author

I've fixed the conflicts, but we should probably decide on whether this new behaviour is actually an improvement, and if you think it is, it might be worth playing around with it more to iron out any corner-case issues there might be.

@Katharine
Copy link
Contributor

This is why I tried getting it to deploy!

@pebble-heroku pebble-heroku temporarily deployed to cloudpebble-sp-pr-252 January 13, 2016 20:19 Inactive
@Spacerat Spacerat temporarily deployed to cloudpebble-sp-pr-252 May 19, 2016 00:45 Inactive
@Spacerat Spacerat added the ui label Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants