Allow running in bash on mac #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This violates ShellChecks SC2006 imparative. If For instance, MacOS has the tendency to ship older (outdated) versions of BASH (v3 or even v2). This issue might be resolved by updating the used bash version. |
Potherca
reviewed
Sep 19, 2023
| @@ -21,8 +21,8 @@ function setup { | |||
| } | |||
|
|
|||
| function teardown { | |||
| docker stop "$(docker ps --filter network=testnet -q)" | |||
| docker rm "$(docker ps --filter network=testnet -qa)" | |||
| docker stop `docker ps --filter network=testnet -q` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.