Merge pull request #117 from pdsinterop/feature/multi-headers

fix for sending multiple headers with the same value
pdsinterop · Feb 4, 2023 · a5736be · a5736be
2 parents 063123d + b05fb0e
commit a5736be
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/solid/lib/Controller/CalendarController.php b/solid/lib/Controller/CalendarController.php
@@ -235,9 +235,7 @@ private function respond($response) {
 		$result = new PlainResponse($body);
 
 		foreach ($headers as $header => $values) {
-			foreach ($values as $value) {
-				$result->addHeader($header, $value);
-			}
+			$result->addHeader($header, implode(", ", $values));
 		}
 
 		$result->setStatus($statusCode);

diff --git a/solid/lib/Controller/ContactsController.php b/solid/lib/Controller/ContactsController.php
@@ -236,11 +236,9 @@ private function respond($response) {
 		$result = new PlainResponse($body);
 
 		foreach ($headers as $header => $values) {
-			foreach ($values as $value) {
-				$result->addHeader($header, $value);
-			}
+			$result->addHeader($header, implode(", ", $values));
 		}
-		
+
 		$result->setStatus($statusCode);
 		return $result;
 	}

diff --git a/solid/lib/Controller/ProfileController.php b/solid/lib/Controller/ProfileController.php
@@ -256,9 +256,7 @@ private function respond($response) {
 		$result = new PlainResponse($body);
 
 		foreach ($headers as $header => $values) {
-			foreach ($values as $value) {
-				$result->addHeader($header, $value);
-			}
+			$result->addHeader($header, implode(", ", $values));
 		}
 //		$origin = $_SERVER['HTTP_ORIGIN'] ?? "*";
 //		$result->addHeader('Access-Control-Allow-Credentials', 'true');

diff --git a/solid/lib/Controller/StorageController.php b/solid/lib/Controller/StorageController.php
@@ -399,10 +399,9 @@ private function respond($response) {
 		$result = new PlainResponse($body);
 
 		foreach ($headers as $header => $values) {
-			foreach ($values as $value) {
-				$result->addHeader($header, $value);
-			}
+			$result->addHeader($header, implode(", ", $values));
 		}
+
 //		$origin = $_SERVER['HTTP_ORIGIN'];
 //		$result->addHeader('Access-Control-Allow-Credentials', 'true');
 //		$result->addHeader('Access-Control-Allow-Headers', 'Content-Type, Authorization');