Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added syslogd functionality #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cvetomird91
Copy link

Hello,

I noticed that the pCloud console client didn't log messages to the Linux logging facility. I used syslog.h to add this functionality. I tested it on Fedora 25, which directly logs the messages to the systemd logging facility.

@sergeyklay
Copy link

How about this :)

#define DEBUG_FILE "/tmp/psync_err.log"

As well as:

$ grep -E -nr 'tmp.*\.log' ./pCloudCC 2>/dev/null
./pCloudCC/lib/poverlay_linux/debug.h:25:#define DEBUG_FILE "/tmp/overlay_client.log"
./pCloudCC/lib/pclsync/plibs.h:59:#define DEBUG_FILE "/tmp/psync_err.log"
./pCloudCC/lib/pclsync/lib/poverlay/ShellExt.cpp:34:  _logfile.open("c:\\tmp\\overlaydll.log", std::fstream::out | std::fstream::app | std::fstream::ate);
./pCloudCC/lib/pclsync/lib/poverlay_linux/debug.h:25:#define DEBUG_FILE "/tmp/overlay_client.log"

@Cvetomird91
Copy link
Author

@sergeyklay thanks for addressing this PR. :) Do you suggest using those macros instead of logging to syslog?

@sergeyklay
Copy link

sergeyklay commented Jul 8, 2021

@Cvetomird91 I mean, this PR don't completely cover the idea of logging and actually just add +1 place where the logs might be. It would be better to either get rid of the files altogether, or write only to files (in terms of consistency and program design).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants