Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update access.py #533

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Update access.py #533

merged 1 commit into from
Oct 23, 2024

Conversation

anton-seaice
Copy link
Collaborator

This fixes a syntax error:

access_restarts = ['mice.nc']
access_restarts.append(['u_star.nc', 'sicemass.nc'])
access_restarts
['mice.nc', ['u_star.nc', 'sicemass.nc']]

Should be

access_restarts = ['mice.nc']
access_restarts.extend(['u_star.nc', 'sicemass.nc'])
access_restarts
['mice.nc', 'u_star.nc', 'sicemass.nc']

This fixes a syntax error:

>>> access_restarts = ['mice.nc']
>>> access_restarts.append(['u_star.nc', 'sicemass.nc'])
>>> access_restarts
['mice.nc', ['u_star.nc', 'sicemass.nc']]

Should be 

>>> access_restarts = ['mice.nc']
>>> access_restarts
['mice.nc']
>>> access_restarts.extend(['u_star.nc', 'sicemass.nc'])
>>> access_restarts
['mice.nc', 'u_star.nc', 'sicemass.nc']
@anton-seaice anton-seaice self-assigned this Oct 23, 2024
@anton-seaice
Copy link
Collaborator Author

@blimlin - If you can have a look please that would be handy :)

@coveralls
Copy link

Coverage Status

coverage: 58.546% (+0.2%) from 58.361%
when pulling b902549 on anton-seaice-patch-1
into 7c885b8 on master.

Copy link
Collaborator

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, changes look good to me!

@anton-seaice anton-seaice merged commit 74be036 into master Oct 23, 2024
8 checks passed
@anton-seaice anton-seaice deleted the anton-seaice-patch-1 branch October 23, 2024 05:13
@aidanheerdegen
Copy link
Collaborator

I don't want to be a Mr Meany, but it's good form to have an issue that describes the problem that is being solved, and then close it with the PR fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants