MRU caching initial implementation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Soreloser2
added a commit
that referenced
this pull request
Feb 13, 2023
paulstn
approved these changes
Feb 13, 2023
needs more tests some race conditions
Soreloser2
added a commit
that referenced
this pull request
Feb 15, 2023
* Create node.js.yml WIP still need a test runner * added test script * updated to only use node 18 * added files that will be introduced in PR #32 * Merge with main, fixed some test errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of #23
Adds MRU caching to keep track of last used tab ids. Tests all passing
except for the keyboard shortcut, which is skipped because I'm not sure how to mock command triggers using puppeteer.EDIT: extracted switch tab into a separate method and tested. Could maybe use some more tests in general for larger cases.Next step is probably to add more info to the cache so preview has something to show, or to make it work with multiple windows.
run tests with
node test/integration/test-switch-tab.js