"cast to int" now rounds half to even #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alancai98
reviewed
Oct 21, 2022
There was a problem hiding this comment.
Thanks for the correction. Think these modified tests should be moved to the partiql-tests-data-extended until #39 is resolved.
| @@ -310,7 +310,7 @@ basic::[ | |||
| output:$bag::[ | |||
| 0, | |||
| 1, | |||
| 1, | |||
| 2, | |||
There was a problem hiding this comment.
Could you move this test and the tests adjusted in cast.ion to partiql-tests-data-extended? As part of #39, we'll define the numeric modeling semantics (including rounding behavior) in the conformance tests.
alancai98
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the behavior of "casting a number to int" to round half to even. Related issue: partiql/partiql-lang-kotlin#783