Adds Kotlin test runner to verify ported tests are ported correctly #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alancai98
commented
Sep 21, 2022
...ql-tests-kotlin-test-runner/src/test/kotlin/org/partiql/tests/kotlintestrunner/TestRunner.kt
Show resolved
Hide resolved
| sealed class Assertion { | ||
| data class EvaluationSuccess(val expectedResult: IonValue) : Assertion() | ||
| object EvaluationFailure : Assertion() | ||
| // TODO: other assertion and test categories: https://github.com/partiql/partiql-tests/issues/35 |
There was a problem hiding this comment.
Since the test runner came out of discussion related to evaluation tests, I decided to only test the evaluation and evaluation equivalence tests in this PR. Other test categories will be added in a future PR as part of #35
am357
previously approved these changes
Sep 22, 2022
...ql-tests-kotlin-test-runner/src/test/kotlin/org/partiql/tests/kotlintestrunner/TestRunner.kt
Show resolved
Hide resolved
partiql-tests-kotlin-test-runner/src/test/kotlin/org/partiql/tests/kotlintestrunner/Parse.kt
Show resolved
Hide resolved
...lin-test-runner/src/test/kotlin/org/partiql/tests/kotlintestrunner/PartiQLEqualityChecker.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // typed nulls | ||
| if (!left.isMissing() && !right.isMissing() && (left.isNullValue || right.isNullValue)) { |
There was a problem hiding this comment.
nit: The long if could be moved to a function for better readability.
1 task
|
After discussing with Josh, it makes sense to move the Kotlin test runner to |
jpschorr
reviewed
Sep 23, 2022
jpschorr
previously approved these changes
Sep 23, 2022
jpschorr
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #33.
Adds a Kotlin test runner to verify that the ported evaluation and evaluation equivalence tests are ported correctly using
partiql-lang-kotlin's evaluator. This should help us verify the evaluation tests are ported correctly frompartiql-lang-kotlinand help speed up the future review process for those PRs.Found a few mistakes in about 8 existing tests. Also went through and identified about ~60 tests that the
partiql-lang-kotlinimplementation diverges from the defined conformance tests (see this review comment for further discussion).Future work:
partiql-lang-kotlin's evaluation tests are all ported topartiql-tests): Create apartiql-testsTest Runner and replace duplicated tests partiql-lang-kotlin#789By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.