Tessera does not consistently connect to all peers in the network in Recovery mode #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodion-lim-partior
approved these changes
Jul 10, 2024
| LOGGER.info("Waiting for nodes to synchronise with peers"); | ||
| Thread.sleep(10000); | ||
| final var waitTimeBeforeRecoveryStartsInMillis = | ||
| intervalPropertyHelper.partyInfoInterval() * 2L; |
There was a problem hiding this comment.
this portion is grey, party info of another node might be scheduled at a different interval from your own tessera
There was a problem hiding this comment.
That is correct. Since the startup delay is now configurable, the recovery node should set its partyInfoInterval to the maximum partyInfoInterval of other peers. This will allow the recovery node to have enough time to wait for all active peers to sync up with it.
krishnan-narayanan-partior
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Issue where Node is not able to consistently connect to peers during recovery mode
In recovery mode, Tessera waits for 10 seconds before initiating the main recovery procedure. This 10-second value is currently hard-coded. However, if a peer's partyInfoInterval exceeds 10 seconds, the node in recovery may not provide sufficient time for peers to inform it about the peer's party info. Consequently, there is a risk that the recovery node might consider the peer inactive.
To address this issue, the 10-second wait time should be adjusted dynamically to twice the partyInfoInterval. This adjustment ensures that recovery nodes and their peers have adequate time to synchronize their partyInfo, enhancing the accuracy and reliability of the recovery process.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog