Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom invalid characters (#57) #58

Closed
wants to merge 22 commits into from
Closed

Custom invalid characters (#57) #58

wants to merge 22 commits into from

Commits on Apr 8, 2020

  1. ran npm audit fix

    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    1ca1541 View commit details
    Browse the repository at this point in the history

  2. added new feature: additional invalid characters 

    - added new functionality in index.js
- added new tests and confirmed current tests are still working
- added new TypeScript declarations
    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    bb9016f View commit details
    Browse the repository at this point in the history

  3. updated jsdoc

    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    6f49e84 View commit details
    Browse the repository at this point in the history

  4. remove additional invalids first 

    - this helps to cope with certain cenarios
    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    6abc74c View commit details
    Browse the repository at this point in the history

  5. added further testing 

    - more complex tests
- used some additional invalids when testing with FS, some from blns
    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    41dc758 View commit details
    Browse the repository at this point in the history

  6. handle replacement functions 

    - only check if replacement is part of invalids if it's a string and not a function
    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    5251bfb View commit details
    Browse the repository at this point in the history

  7. updated readme

    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    91a1fb5 View commit details
    Browse the repository at this point in the history

  8. edge cases 

    - implemented replacement of recursive patterns (this causes some restrictions with options.invalid)
- added error handling for unsupported cases
    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    038971a View commit details
    Browse the repository at this point in the history

  9. modified tests to account for new edge cases

    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    6f57187 View commit details
    Browse the repository at this point in the history

  10. rename option from 'invalid' to 'additionalInvalids' for clarity

    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    07704fd View commit details
    Browse the repository at this point in the history

  11. more renaming and fixed typos

    @Chaphasilor
    Chaphasilor committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    da93854 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. convert to ES5

    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    e4b609b View commit details
    Browse the repository at this point in the history

  2. rename option to 'additionalInvalidStrings'

    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ea2bd1e View commit details
    Browse the repository at this point in the history

  3. replace keyword 'const' with 'var' 

    - also removed unneeded object
    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    057e3e9 View commit details
    Browse the repository at this point in the history

  4. replaced backticks with "

    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    7365cdb View commit details
    Browse the repository at this point in the history

  5. remove shorthand from for loop

    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    020a4ee View commit details
    Browse the repository at this point in the history

  6. move counter declaration to prevent re-initialization

    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    99cde11 View commit details
    Browse the repository at this point in the history

  7. replace String.includes() with String.indexOf

    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    0dd8b47 View commit details
    Browse the repository at this point in the history

  8. properly handle replacement function

    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    6ec3383 View commit details
    Browse the repository at this point in the history

  9. add test for illegal replacement function

    @Chaphasilor
    Chaphasilor committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    8843c20 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. check type of replacement

    @Chaphasilor
    Chaphasilor committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    05a7f43 View commit details
    Browse the repository at this point in the history

  2. added more tests 

    - added test for wrong type of replacement function
- added tests for making sure replacement function works with additional invalids
    @Chaphasilor
    Chaphasilor committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    4ba9696 View commit details
    Browse the repository at this point in the history