refactor and harden check_core_index #6217
Open
+60
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alindima
added
the
T8-polkadot
sandreim
reviewed
Oct 24, 2024
| } | ||
|
|
||
| match UMPSignal::decode(&mut core_selector_message.as_slice()) | ||
| .map_err(|_| CandidateReceiptError::InvalidSelectedCore)? |
There was a problem hiding this comment.
This is error should read as invalid ump signal.
sandreim
reviewed
Oct 24, 2024
| Some(core_index) | ||
| }) | ||
| let core_selector = core_selector | ||
| .or_else(|| if assigned_cores.len() == 1 { Some(CoreSelector(0)) } else { None }) |
There was a problem hiding this comment.
We need to still allow v2 candidates without core selectors, only if the MVP bit is enabled, because they will have an injected core index and will be valid candidates in the runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6179
Still have to fix tests