Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrations for pallet-xcm #6148

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Oct 21, 2024

Relates to: #4826
Relates to: #3214

Description

pallet-xcm stores some operational data that uses Versioned* XCM types. When we add a new XCM version (XV), we deprecate XV-2 and remove XV-3. Without proper migration, this can lead to issues with undecodable storage, as was identified on the XCMv5 branch where XCMv2 was removed.

This PR extends the existing MigrateToLatestXcmVersion to include migration for the Queries, LockedFungibles, and RemoteLockedFungibles storage types. Additionally, more checks were added to try_state for these types.

TODO

VersionNotifier: {
        origin: {
          V2: {
            parents: 0
            interior: {
              X1: {
                Parachain: 2,124
              }
            }
          }
        }
        isActive: true
      } 

image

  • fix also for RemoteLockedFungibles
  • fix also for LockedFungibles

Follow-ups

# Conflicts:
#	polkadot/runtime/westend/src/lib.rs
This was referenced Oct 21, 2024
@bkontur
Copy link
Contributor Author

bkontur commented Oct 23, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 23, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7624303 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 29-6fd92f1d-1fe8-4b59-8989-f98e7014a4f5 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 23, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7624303 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7624303/artifacts/download.

@bkontur bkontur added the T6-XCM This PR/Issue is related to XCM. label Oct 23, 2024
@bkontur
Copy link
Contributor Author

bkontur commented Oct 23, 2024

/cmd prdoc

@bkontur bkontur added the A3-backport Pull request is already reviewed well in another branch. label Oct 23, 2024
@bkontur bkontur marked this pull request as ready for review October 23, 2024 10:07
@bkontur bkontur requested a review from a team as a code owner October 23, 2024 10:07
@bkontur bkontur added A4-needs-backport Pull request must be backported to all maintained releases. and removed A3-backport Pull request is already reviewed well in another branch. labels Oct 23, 2024
@bkontur bkontur self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T6-XCM This PR/Issue is related to XCM.
Projects
Status: In-Review
Development

Successfully merging this pull request may close these issues.

3 participants