[pallet-revive] Add Ethereum JSON-RPC server #6147
Conversation
| @@ -48,7 +48,7 @@ type CallOf<T> = <T as frame_system::Config>::RuntimeCall; | |||
| /// We use a fixed value for the gas price. | |||
| /// This let us calculate the gas estimate for a transaction with the formula: | |||
| /// `estimate_gas = substrate_fee / gas_price`. | |||
| pub const GAS_PRICE: u32 = 1_000u32; | |||
| pub const GAS_PRICE: u32 = 1u32; | |||
There was a problem hiding this comment.
Is this intentional? Might also be worthwhile to explain the bases of the estimate in the comment
There was a problem hiding this comment.
Yeah I think either value is fine since they are constant
1 is nice since we can compute tx.gas = dry_run.fee / GAS_PRICE, there are no rest to the division
| #[async_trait] | ||
| impl MiscRpcServer for MiscRpcServerImpl { | ||
| async fn healthcheck(&self) -> RpcResult<()> { | ||
| Ok(()) |
There was a problem hiding this comment.
Is the idea here just to be able to ping the server?
Wondering why this is a trait, seems like if this is just to have a ping like check it seems superfluous to have a trait for it.
There was a problem hiding this comment.
Is the idea here just to be able to ping the server?
Yes, a trait for every other rpc.
I can probably remove this one for now,
with jsonrpsee crate you define your rpc on a trait with the #[rpc] macro and then implement it on the server, the client trait is generated as well for you through this Macro.
Redo of #5953