Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing strategy refactoring (part 3) #5737

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Syncing strategy refactoring (part 3) #5737

wants to merge 21 commits into from

Commits on Sep 17, 2024

  1. Use SyncingAction everywhere instead of custom enums in different s… 

    …trategies
    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0515f8f View commit details
    Browse the repository at this point in the history

  2. Make strategy key opaque instead of having a hardcoded list of variants

    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    743161c View commit details
    Browse the repository at this point in the history

  3. Rename SyncingConfig to PolkadotSyncingStrategyConfig

    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e393d30 View commit details
    Browse the repository at this point in the history

  4. Move PolkadotSyncingStrategy into its own module

    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6b5acc4 View commit details
    Browse the repository at this point in the history

  5. Replace SyncingAction::SendWarpProofRequest and `SyncingStrategy::o… 

    …n_warp_proof_response()` with `SyncingAction::SendGenericRequest` and `SyncingStrategy::on_generic_response()`
    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a312e09 View commit details
    Browse the repository at this point in the history

  6. Replace state sync request/response handling with generic one

    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    72908d3 View commit details
    Browse the repository at this point in the history

  7. Replace SyncingAction::SendGenericRequest with more generic `Syncin… 

    …gAction::StartRequest`
    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c727dc1 View commit details
    Browse the repository at this point in the history

  8. Move block downloader instantiation outside the network instantiation

    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6bf9b7f View commit details
    Browse the repository at this point in the history

  9. Move ChainSync::on_block_response implementation out of the trait i… 

    …mpl block
    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    76b2dcf View commit details
    Browse the repository at this point in the history

  10. Pass protocol name down to generic response handler

    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a1a0863 View commit details
    Browse the repository at this point in the history

  11. Replace SyncingAction::SendBlockRequest and `SyncingStrategy::on_bl… 

    …ock_response()` with `SyncingAction::StartRequest` and `SyncingStrategy::on_generic_response()`
    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d2ab786 View commit details
    Browse the repository at this point in the history

  12. Improve import queue API, removing the need for Box<dyn Link<B>> if… 

    … we already effectively more common `Arc<dyn Link<B>>` in many places
    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0ae9dc0 View commit details
    Browse the repository at this point in the history

  13. Remove syncing engine construction from build_network and expose `b… 

    …uild_default_syncing_engine` to make construction of the default syncing engine a bit easier
    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a26bbfa View commit details
    Browse the repository at this point in the history

  14. Add prdoc

    @nazar-pc
    nazar-pc committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    53b34d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Rename build_network to build_network_advanced and restore `build… 

    …_network` API before paritytech#5666
    @nazar-pc
    nazar-pc committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0ac0ddf View commit details
    Browse the repository at this point in the history

  2. Make build_network_advanced arguments lower-level and not require `… 

    …sc_service::Configuration`
    @nazar-pc
    nazar-pc committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8388a81 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into syncing-strategy-… 

    …refactoring-part-3

# Conflicts:
#	substrate/client/network/sync/src/engine.rs
    @nazar-pc
    nazar-pc committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    243af75 View commit details
    Browse the repository at this point in the history

  4. Fix toml formatting

    @nazar-pc
    nazar-pc committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    63dbf0f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Change name of generics for consistency

    @nazar-pc
    nazar-pc committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7f4ce2c View commit details
    Browse the repository at this point in the history

  2. Remove redundant comment (present in places that set `remove_obsolete… 

    …: true`
    @nazar-pc
    nazar-pc committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    87be088 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into syncing-strategy-… 

    …refactoring-part-3

# Conflicts:
#	substrate/client/network/sync/src/strategy/chain_sync.rs
    @nazar-pc
    nazar-pc committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    27ee43c View commit details
    Browse the repository at this point in the history