Switch node side to v2 candidate receipts #5679
Open
+1,136
−721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
alindima
reviewed
Oct 2, 2024
polkadot/node/network/collator-protocol/src/validator_side/collation.rs
Outdated
Show resolved
Hide resolved
| fn set_para_head(&mut self, para_head: Hash); | ||
| } | ||
|
|
||
| #[cfg(feature = "test")] |
There was a problem hiding this comment.
I'd rather directly add these methods onto the CandidateDescriptorV2 and guard each of them with #[cfg(test)], which would save us the import of MutateDescriptorV2. But fine either way really
prdoc/pr_5679.prdoc
Outdated
Comment on lines
15
to
18
| - name: cumulus-client-consensus-common | ||
| bump: major | ||
| - name: cumulus-client-pov-recovery | ||
| bump: major |
There was a problem hiding this comment.
why are these two major? I think they should be none
actually, why is everything a major bump? :D
There was a problem hiding this comment.
I've switched the subsystem messages and cumulus traits to new primtives so this breaks things.
Also I'm missing many crates here and the check fails.
Base automatically changed from
sandreim/runtime_v2_descriptor_support
to
master
October 7, 2024 07:22
2 tasks
|
/cmd prdoc --audience node_dev,runtime_dev --bump major |
Signed-off-by: Andrei Sandu <[email protected]>
…reim/node_v2_descriptors Signed-off-by: Andrei Sandu <[email protected]>
|
/cmd prdoc --audience node_dev,runtime_dev --bump major |
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
|
/cmd prdoc --audience node_dev,runtime_dev --bump major |
|
/cmd prdoc --audience node_dev runtime_dev --bump major |
…me_dev --bump major'
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
alindima
approved these changes
Oct 22, 2024
Signed-off-by: Andrei Sandu <[email protected]>
Signed-off-by: Andrei Sandu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #5423
This PR implements the plumbing work required for #5047 . I also added additional helper methods gated by feature "test" in primitives.
TODO: