pallet macro: Support instantiable pallets in tasks #5194
Merged
+392
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
commented
Jul 31, 2024
| pub fn expand_tasks(def: &mut Def) -> TokenStream2 { | ||
| if let Some(tasks_def) = &def.tasks { | ||
| if def.task_enum.is_none() { | ||
| def.task_enum = Some(TaskEnumDef::generate( |
There was a problem hiding this comment.
In this PR we no longer modify the Def to insert a generated task_enum in case none were provided.
Instead we just expand what we need without modifying the Def in the expand phase.
As a result we need to use tasks instead of task_enum for generating the automatic part later.
But all in all behavior is not changed
ggwpez
approved these changes
Aug 10, 2024
|
More eyes on this 🙏 |
bkchr
approved these changes
Oct 20, 2024
| let ident = &self.item_enum.ident; | ||
| let vis = &self.item_enum.vis; | ||
| let attrs = &self.item_enum.attrs; | ||
| let generics = &self.item_enum.generics; |
There was a problem hiding this comment.
These should be the same as type_use_generics, if not we would have some problem. I think we should remove generics and just use the type_use_generics.
There was a problem hiding this comment.
I added a check for generics at eb3061c
Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5185
also implement handling of attr in expansion in construct-runtime