Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridges V2 refactoring backport and pallet_bridge_messages simplifications #4935

Merged
merged 64 commits into from
Jul 12, 2024

Commits on Jun 26, 2024

  1. Use compact proofs for messages delivery (#2155)

    * Define Chain::STATE_VERSION
    
    * Add vec_db module
    
    * Use VecDb instead of StorageProof for message delivery
    
    * Make sure that the TrustedVecDb is sorted
    
    * Address review comments
    
    * Run benchmarks on parent commit
    
    * Run benchmarks with new code
    
    * Fix test
    
    * Fix code review comments
    serban300 authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bc0f814 View commit details
    Browse the repository at this point in the history
  2. Moved FromBridgedChainMessagesDeliveryProof to bp-messages (#2169)

    * moved FromBridgedChainMessagesDeliveryProof to bp-messages
    
    * spelling
    
    * fix benchmarks compilation
    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    18b5b22 View commit details
    Browse the repository at this point in the history
  3. Moved FromBridgedChainMessagesProof to bp-messages (#2170)

    * moved FromBridgedChainMessagesProof to bp-messages
    
    * fmt
    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    379a600 View commit details
    Browse the repository at this point in the history
  4. Separate folder for messages in relay lib (#2173)

    * moved message files to separate folder
    
    * ...and fix paths in code
    
    * fmt
    
    rebase nit
    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7b5b01c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0278a54 View commit details
    Browse the repository at this point in the history
  6. Improve receive_messages_proof benchmarks accuracy (#2176)

    * Adjust messages pallet benchmarks
    
    * Address comment
    serban300 authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9197d85 View commit details
    Browse the repository at this point in the history
  7. Moving messages code to pallet (#2180)

    * moved files around
    
    * and fix compilation
    
    Move Chain::ID from relay-level Chain to primitives-level Chain (#2181)
    
    * move Chain::ID from relay-level Chain to primitives-level Chain
    
    * removed chain IDs from bp-runtime
    
    * add missing file header
    
    Adjust weights (#2185)
    
    fix clippy (#2186)
    
    Remove source header chain (#2183)
    
    * moved messages proof verification to messages pallet
    
    * removed SourceHeaderChain
    
    * cleanup
    
    * benchmarks compilation
    
    * fix benchmark tests compilation
    
    * clippy
    
    * fmt
    
    Use compact proofs for messages delivery confirmation (#2187)
    
    * Use compact proofs for messages delivery confirmation
    
    * Fix benchmarks
    
    Move messages delivery proof verification to pallet (#2189)
    
    * rename messages_proof.rs to proofs.rs
    
    * moved delivery proof verification to the messages pallet
    
    * removed TargetHeaderChain
    
    * cleaning up
    
    * fixed benchmarks compilation
    
    * Update modules/messages/README.md
    
    Co-authored-by: Adrian Catangiu <[email protected]>
    
    * uncommented test and removed printlns
    
    * vec![].into_iter().collect() -> vec![].into()
    
    ---------
    
    Co-authored-by: Adrian Catangiu <[email protected]>
    
    removed MaxUnrewardedRelayerEntriesAtInboundLane and MaxUnconfirmedMessagesAtInboundLane from messages pallet config (#2190)
    
    * removed MaxUnrewardedRelayerEntriesAtInboundLane and MaxUnconfirmedMessagesAtInboundLane from messages pallet config
    
    * fixed doc
    
    * fixed benchmarking code
    
    * more fixes
    
    remove MaximalOutboundPayloadSize and use BridgedChain::maximal_incomging_message_size instead (#2191)
    
    remove MessageBridge trait (#2192)
    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7c46371 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    acb15cc View commit details
    Browse the repository at this point in the history
  9. Use compact proofs for parachains (#2194)

    * Use compact proofs for parachains
    
    * Remove StorageProofChecker
    
    * Cleanup
    
    Reuse messages proof generation from messages pallet (#2195)
    
    * reuse messages proof generation from messages pallet
    
    * incorrect merge
    
    fixed remaining TODOs after messages pallet Config refactoring (#2196)
    
    Return UntrustedVecDb from prove_storage() (#2197)
    
    Storage proofs related renamings (#2198)
    
    * Storage proofs related renamings
    
    * Leftovers
    
    * StorageSize -> StorageProofSize
    serban300 authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    91d6f6b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    11cd08c View commit details
    Browse the repository at this point in the history
  11. Fix maximal message dispatch weight (#2219)

    * add test for maximal message dispatch weight
    
    * fixed weight computations - use kb for both size-related benchmarks
    
    * fix typo in weight formula
    
    * decreased maximal message size to 64Kb
    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e5acef8 View commit details
    Browse the repository at this point in the history
  12. Box messages proof argument in receive_messages_proof call (#2222)

    * Box messages proof argument in receive_messages_proof call
    
    * fix benchmark tests
    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5303b2c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6019c51 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4cbee73 View commit details
    Browse the repository at this point in the history
  15. fix some nightly errors (#2225)

    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1265806 View commit details
    Browse the repository at this point in the history
  16. Renamings (#2226)

    * StorageProofSize -> StorageSize
    
    * Rename benchmarks
    
    * StorageSize -> UnverifiedStorageProofParams
    
    * Fix clippy
    
    * Fix priority boost
    serban300 authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8a1d006 View commit details
    Browse the repository at this point in the history
  17. Fix clippy (#2240)

    * update async-trait to 0.1.69
    
    * more clippy fixes
    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ccf2919 View commit details
    Browse the repository at this point in the history
  18. Some code grooming (#2276)

    * some code grooming: enable warn(missing_docs) for all piblic crates + added missing documentation + removed obsolete clippy/deny workarounds
    
    * removed strange allow + added comment related to other allow
    
    * removed incorrect_clone_impl_on_copy_type which is unknown to CI clippy
    svyatonik authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    37225c0 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    f06c39f View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    e2e7be3 View commit details
    Browse the repository at this point in the history
  21. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa
    
    ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers
    
    ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers
    
    ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_parachains
    
    ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_parachains
    
    ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa
    
    ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages
    
    ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages
    command-bot authored and bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0325bdc View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    948e4ab View commit details
    Browse the repository at this point in the history
  23. zepter+taplo

    bkontur committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b1b6ccf View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    096aca1 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Configuration menu
    Copy the full SHA
    7e6b6b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8a40ef View commit details
    Browse the repository at this point in the history
  3. Updated new substrate-relay version `v2.0.0-rc1-compact-proof-ro-we…

    …` with compact proofs
    bkontur committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    cdd1280 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    bcf8050 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    ded4e86 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c94e43 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    94e977d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    19f4011 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a367b49 View commit details
    Browse the repository at this point in the history
  6. Fixes

    bkontur committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    6dbbb48 View commit details
    Browse the repository at this point in the history
  7. nits

    bkontur committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3a149d9 View commit details
    Browse the repository at this point in the history
  8. CI fixes

    bkontur committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e4a1c5b View commit details
    Browse the repository at this point in the history
  9. more nits

    bkontur committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    abd140f View commit details
    Browse the repository at this point in the history
  10. fmt

    bkontur committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    685bcb4 View commit details
    Browse the repository at this point in the history
  11. Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

    …nto HEAD
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cd6b1c7 View commit details
    Browse the repository at this point in the history
  12. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_parachains
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2a3d5cc View commit details
    Browse the repository at this point in the history
  13. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    39a5340 View commit details
    Browse the repository at this point in the history
  14. ".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=br…

    …idge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    dcb550f View commit details
    Browse the repository at this point in the history
  15. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    45155b3 View commit details
    Browse the repository at this point in the history
  16. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_relayers
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    43dcfc0 View commit details
    Browse the repository at this point in the history
  17. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_parachains
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    27dfe41 View commit details
    Browse the repository at this point in the history
  18. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    25ed0da View commit details
    Browse the repository at this point in the history
  19. ".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=br…

    …idge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    387e624 View commit details
    Browse the repository at this point in the history
  20. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e2635b5 View commit details
    Browse the repository at this point in the history
  21. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_messages
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    612cf2d View commit details
    Browse the repository at this point in the history
  22. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    6047fa9 View commit details
    Browse the repository at this point in the history
  23. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_bridge_hub_router
    command-bot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    32d7455 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    233fb44 View commit details
    Browse the repository at this point in the history
  25. Adjust fees and prdoc

    bkontur committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    0f1c5ff View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    24b3a12 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. macro nit + prdoc

    bkontur committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cf42701 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e4c70d View commit details
    Browse the repository at this point in the history
  3. Review comments

    bkontur committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1ed7df7 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Nits

    bkontur committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    308ec4a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. [bridges] Prune messages from confirmation tx body, not from the on_i…

    …dle (#4944)
    
    Original PR with more context:
    paritytech/parity-bridges-common#2211
    Relates to:
    paritytech/parity-bridges-common#2210
    
    ## TODO
    
    - [x] fresh weighs for `pallet_bridge_messages`
    - [x] add `try_state` for `pallet_bridge_messages` which checks for
    unpruned messages - relates to the
    [comment](paritytech/parity-bridges-common#2211 (comment))
    - [x] ~prepare migration, that prunes leftovers, which would be pruned
    eventually from `on_idle` the
    [comment](paritytech/parity-bridges-common#2211 (comment)
    can be done also by `set_storage` / `kill_storage` or with
    `OnRuntimeUpgrade` implementatino when `do_try_state_for_outbound_lanes`
    detects problem.
    
    ## Open question
    
    - [ ] Do we really need `oldest_unpruned_nonce` afterwards?
    - after the runtime upgrade and when `do_try_state_for_outbound_lanes`
    pass, we won't need any migrations here
        - we won't even need `do_try_state_for_outbound_lanes`
    
    ---------
    
    Signed-off-by: Branislav Kontur <[email protected]>
    Co-authored-by: Svyatoslav Nikolsky <[email protected]>
    Co-authored-by: command-bot <>
    bkontur and svyatonik authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    7c875be View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

    …nto HEAD
    command-bot committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    09a306f View commit details
    Browse the repository at this point in the history
  2. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa
    command-bot committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1dc37bc View commit details
    Browse the repository at this point in the history
  3. ".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

    …=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_bridge_grandpa
    command-bot committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    953e4bd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    397dd61 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    b42bd1c View commit details
    Browse the repository at this point in the history