Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #4089 renewals fix for pallet-broker #4194

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

seadanda
Copy link
Contributor

Part of: #4107

@seadanda seadanda requested a review from a team as a code owner April 18, 2024 12:18
@seadanda
Copy link
Contributor Author

This was cherry picked and released on crates.io. No need to merge.

@seadanda seadanda closed this Apr 24, 2024
@seadanda seadanda deleted the donal-backport-renewal-fix branch April 25, 2024 13:42
@seadanda seadanda restored the donal-backport-renewal-fix branch June 3, 2024 10:20
@seadanda
Copy link
Contributor Author

seadanda commented Jun 3, 2024

Turns out this was only merged into the release-crates-io-v1.7.0 branch, not this release branch.

@seadanda seadanda reopened this Jun 3, 2024
@seadanda seadanda changed the base branch from release-polkadot-v1.7.2 to release-polkadot-v1.7.3 June 3, 2024 10:22
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6378454

@seadanda seadanda merged commit 7fec35e into release-polkadot-v1.7.3 Jun 3, 2024
62 of 135 checks passed
@seadanda seadanda deleted the donal-backport-renewal-fix branch June 3, 2024 12:52
seadanda added a commit that referenced this pull request Jun 3, 2024
When merging the two backports (#4194 and #4656) for the broker pallet,
the priority of the changes seems to have been reversed and ended up
with some broken code.

CI doesn't actually run before merging on these release branches so it
merged with broken tests. `release-` branches are protected so it needs
this PR to remove the duplication. Sorry for the noise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants