Make client code generic over Client type #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
force-pushed
the
client-impl-for-tests
branch
from
aec7fe8
to
fe55414
Compare
svyatonik
changed the title
serban300
approved these changes
May 22, 2023
svyatonik
added a commit
that referenced
this pull request
May 24, 2023
This reverts commit 1a95216.
svyatonik
added a commit
that referenced
this pull request
May 24, 2023
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2133. Writing tests and proper
TestingClientis not trivial, so I've extracted this to a separate issue #2413 2145. So let's this PR will be just about making relayer code generic over theClienttype.Please note that the code in
substrate-relayfolder still uses theCachingClient<RpcClient<C>>everywhere. That's because most of code there contains no any logic and there's nothing to test there. So only code inlib-substrate-relayis generic.