-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for foreign asset multilocations #224
Conversation
…ive in order to allow system chains without assets pallet to create native asset xcm transfers
allow for multilocation string assetIds to be passed in as assetId args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments regarding the examples.
I will do the code review afterwards.
…ilocation asset ids added checks and test cases to error when assetIds are not exclusively either symbol, integer and empty string or multilocation values added checks and test cases to ensure assetIds length are not greater than MAX_ASSETS_FOR_TRANSFER added test case for paysWithFeeDest to ensure xcm version is 3
update dupes to account for white spaces in multilocations
… instance depending on origin
import constructForeignAssetMultiLocationFromAssetId to ParaToSystem and SystemToPara
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small suggestions, and an open discussion point about the sorting function. Great and solid work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
P.S: what is the status regarding the last to-do point "add foreign assets pallet instance from registry"? does that one belong to the registry repo?
Yes, I've updated the registry to fetch the foreignAssetsPalletInstance already. After I do a release of the registry this morning it will be a simple change of pulling the pallet instance from there rather than using a constant. |
update registry type to include foreignAssetsPalletInstance and poolPairsInfo pull foreignAssetsPalletInstance from registry
TODOs:
closes: #140
closes: #229
closes: #230