-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add otel profiling support #4579
Conversation
🤖 Meticulous spotted visual differences in 1 of 336 screens tested: view and approve differences detected. Last updated for commit e8278ad. This comment will update as new commits are pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these files were deleted. rm -r ui/packages/app/grafana-datasource-plugin/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these files were deleted. rm -r ui/packages/app/grafana-panel-plugin/.prettierrc.js
b7988b6
to
86544d2
Compare
77580ac
to
03cbd91
Compare
abf5e75
to
5932b36
Compare
This patch implements the otel-profiling format to be accepted by Parca. Generation is a bit wonky as I needed it to not clash with existing
common
andresource
types, but that will be gone once the official Go library that contains the generated Go code is updated.As this is partly meant to inform otel-profiling format feedback, to reduce our own bias, use, and behavior of the format, instead of implementing support for otel-profiling in Parca-Agent first, this was instead primarily tested for compatibility by trying to ingest data from the otel-profiling-agent.
One thing to note about that is that the otel agent always normalizes addresses, therefore this currently hardcodes that mode, ideally this would actually be indicated by the otel profiling format (I'm going to bring this up in today's otel profiling meeting).