Update cryptoki and cryptoki-sys crates #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgonzalezorlandoarm
commented
Sep 1, 2023
tgonzalezorlandoarm
commented
- Update the cryptoki and cryptoki-sys crates.
- Remove the psa-crypto-conversions feature from the cryptoki dependency in the Cargo.toml file. The psa-crypto crate is already being brought up in the Cargo.toml file and this would lead to a crate conflict when upgrading.
tgonzalezorlandoarm
force-pushed
the
tg/update-cryptoki
branch
from
0d932bb
to
43326c9
Compare
tgonzalezorlandoarm
force-pushed
the
tg/update-cryptoki
branch
3 times, most recently
from
36682ea
to
6c13f83
Compare
tgonzalezorlandoarm
force-pushed
the
tg/update-cryptoki
branch
from
6c13f83
to
61b3b3d
Compare
tgonzalezorlandoarm
added
the
dependencies
tgonzalezorlandoarm
force-pushed
the
tg/update-cryptoki
branch
16 times, most recently
from
bf9aa38
to
2bfc25a
Compare
|
The last commit of the PR is breaking the tests (the tests pass for the previous commit) . What I'm thinking is causing the issue is the introduction of PkcsOaepSource::new and maybe how I'm using it? |
tgonzalezorlandoarm
force-pushed
the
tg/update-cryptoki
branch
2 times, most recently
from
74ff474
to
0cd82ef
Compare
|
This PR depends on parallaxsecond/rust-cryptoki#165 being merged |
tgonzalezorlandoarm
force-pushed
the
tg/update-cryptoki
branch
from
b8e3634
to
43590bc
Compare
tgonzalezorlandoarm
added a commit
to tgonzalezorlandoarm/rust-cryptoki
that referenced
this pull request
Sep 27, 2023
Cryptoki should be using cryptoki-sys latest version, so that when it's pulled by other projects there is no version misalignment. Otherwise, a 'cargo update --package cryptoki-sys' is needed after updating cryptoki. This issue was discovered when trying to update to cryptoki 0.5.0 in parallaxsecond/parsec#697 Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
tg/update-cryptoki
branch
from
43590bc
to
8761fcd
Compare
* Remove the psa-crypto-conversions feature from the cryptoki dependency in the Cargo.toml file. The psa-crypto crate is already being brought up in the Cargo.toml file and this would have lead to a crate conflict when upgrading. * Remove parsec's dependency on cryptoki's psa-crypto by creating helping functions to perform type conversions. Signed-off-by: Tomás González <[email protected]>
* Update the cryptoki and cryptoki-sys crates. * Minor changes to the code to update according to the updates version of cryptoki. Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
tg/update-cryptoki
branch
from
8761fcd
to
ac9a374
Compare
Signed-off-by: Tomás González <[email protected]>
gowthamsk-arm
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.