Make wrong_permitted_algorithm test use a non-deprecated Hash #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the wrong_permitted_algorithm test checks if, creating a key that uses sha1, that key is rejected when calling sign_with_rsa_sha256. However, as sha1 is deprecated, there is currently an error when creating the key for the test. * Change the key generation to use sha512 instead. Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
tg/fix-wrong_permitted_algorithm
branch
from
9220218
to
bb65c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the wrong_permitted_algorithm test checks if, creating a key that uses sha1, that key is rejected when calling sign_with_rsa_sha256. However, as sha1 is deprecated, there is currently an error when creating the key for the test.