Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace extra fields with ExecutionPayloadSidecar in engine #11901

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Oct 19, 2024

Follow up on #11865

Replaces the hack to add execution requests throughout the engine + engine interceptor components with the new ExecutionPayloadSidecar introduced in alloy-rs/alloy#1517. The ExecutionPayloadSidecar replaces both Prague and Cancun fields.

This also finishes Prague integration in the engine interceptors, but does not adjust a lot of the testing code we have to support execution requests.

@onbjerg onbjerg added C-debt Refactor of code section that is hard to understand or maintain A-consensus Related to the consensus engine labels Oct 19, 2024
@onbjerg onbjerg force-pushed the onbjerg/exec-payload-sidecar branch from 38e3089 to 2cb12ef Compare October 19, 2024 23:39
@onbjerg onbjerg changed the title refactor: replace cancun + prague fields with ExecutionPayloadSidecar in engine refactor: replace extra fields with ExecutionPayloadSidecar in engine Oct 19, 2024
@onbjerg onbjerg added the S-blocked This cannot more forward until something else changes label Oct 19, 2024
@onbjerg
Copy link
Member Author

onbjerg commented Oct 19, 2024

This is blocked, ExecutionPayloadSidecar needs to be ser/de upstream because of one of our engine interceptors: alloy-rs/alloy#1535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine C-debt Refactor of code section that is hard to understand or maintain S-blocked This cannot more forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant