refactor: BlockchainTestCase::run rm repetitive convert ForkSpec to ChainSpec #11896
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkysg
force-pushed
the
refactor_ef-tests
branch
from
96b8c7f
to
cea19df
Compare
nkysg
changed the title
mattsse
requested changes
Oct 19, 2024
| @@ -313,11 +313,11 @@ pub enum ForkSpec { | |||
| Unknown, | |||
| } | |||
|
|
|||
| impl From<ForkSpec> for ChainSpec { | |||
| fn from(fork_spec: ForkSpec) -> Self { | |||
| impl From<&ForkSpec> for ChainSpec { | |||
There was a problem hiding this comment.
hmm, converting this & does make much sense for copy types, especially if we do *fork_spec later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
From<ForkSpec> for ChainSpecshould beFrom<&ForkSpec> for ChainSpec, we don't consume ForkSpec.It seems that chain_spec we can only calc once.