Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: feature propagation #11888

Merged
merged 7 commits into from
Oct 19, 2024
Merged

fix: feature propagation #11888

merged 7 commits into from
Oct 19, 2024

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Oct 19, 2024 •
edited
Loading

Feature propagation is broken for a bunch of crates, breaking compiling in some scenarios. e.g. cargo c -p reth-auto-seal-consensus --features optimism fails due to the crate incorrectly propagating the optimism feature.

This PR fixes feature propagation across crates and adds a new lint CI step to keep it consistent.

@liamaharon liamaharon force-pushed the fix-feature-propagation branch 2 times, most recently from 586622b to c154a1c Compare October 19, 2024 07:25
mattsse
mattsse approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, all of these look good and having zepter makes it easy to not violate this again

just need to check how long this takes in ci

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Oct 19, 2024
DaniPopes
DaniPopes approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very useful, thanks!
Compiling takes 1 minute, and running takes 1 second. This is fine.
For reference: zepter

@mattsse mattsse added this pull request to the merge queue Oct 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 19, 2024
@liamaharon liamaharon force-pushed the fix-feature-propagation branch 3 times, most recently from bb148ad to b268f83 Compare October 19, 2024 13:41
@liamaharon
fix: feature propagation
0971015 
Optimize Sender Recovery Process (paradigmxyz#11385)

chore: simplify update fn (paradigmxyz#11880)

bump rust to 1.82 (paradigmxyz#11876)

rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

feat: tasks executor metrics in grafana (paradigmxyz#11815)

Co-authored-by: Dan Cline <[email protected]>

refactor(txpool): small refactor for `InMemoryBlobStore` impl (paradigmxyz#11886)

primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

feat: update el requests for devnet 4 (paradigmxyz#11865)

Co-authored-by: Matthias Seitz <[email protected]>

check more features
@liamaharon liamaharon force-pushed the fix-feature-propagation branch 2 times, most recently from 90307b6 to 60bf4b7 Compare October 19, 2024 13:44
@liamaharon
Copy link
Contributor Author

Fixed conflicts and added serde,test-utils,arbitrary,bench to checked features

@liamaharon
Squashed merge of the following commits:
cf94e9e 
commit 1a1aa2f
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:18:20 2024 +0200

    feat: add map_pool fn (paradigmxyz#11890)

commit ddc5ac3
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 15:12:28 2024 +0200

    refactor(rpc): small refactor in `trace_filter` (paradigmxyz#11894)

commit 3793b90
Author: Matthias Seitz <[email protected]>
Date:   Sat Oct 19 15:05:53 2024 +0200

    chore: better start finish persisted block logs (paradigmxyz#11893)

    Co-authored-by: Oliver <[email protected]>

commit 3bd695e
Author: Oliver <[email protected]>
Date:   Sat Oct 19 14:48:35 2024 +0200

    feat: update el requests for devnet 4 (paradigmxyz#11865)

    Co-authored-by: Matthias Seitz <[email protected]>

commit 2ae9368
Author: Arsenii Kulikov <[email protected]>
Date:   Sat Oct 19 14:08:34 2024 +0400

    refactor: move `EngineValidator` setup to `RpcAddOns` (paradigmxyz#11850)

commit da5079d
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:42 2024 +0200

    test(txpool): add unit test for `BlobStoreCanonTracker` (paradigmxyz#11885)

commit 2f559c6
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:28:10 2024 +0200

    primitives: use alloy `MAXIMUM_EXTRA_DATA_SIZE` constant (paradigmxyz#11881)

commit a6daafc
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 10:27:29 2024 +0200

    refactor(txpool): small refactor for `InMemoryBlobStore` impl
(paradigmxyz#11886)

commit a4126b3
Author: greged93 <[email protected]>
Date:   Sat Oct 19 00:15:08 2024 +0200

    feat: tasks executor metrics in grafana (paradigmxyz#11815)

    Co-authored-by: Dan Cline <[email protected]>

commit 655fc1a
Author: Thomas Coratger <[email protected]>
Date:   Sat Oct 19 00:13:02 2024 +0200

    rpc: add unit tests for `RpcModuleSelection` (paradigmxyz#11883)

commit eee5e0d
Author: Thomas Coratger <[email protected]>
Date:   Fri Oct 18 22:08:09 2024 +0200

    bump rust to 1.82 (paradigmxyz#11876)

commit a908f97
Author: Matthias Seitz <[email protected]>
Date:   Fri Oct 18 20:21:55 2024 +0200

    chore: simplify update fn (paradigmxyz#11880)

commit 587c91f
Author: Ayodeji Akinola <[email protected]>
Date:   Fri Oct 18 16:17:11 2024 +0100

    Optimize Sender Recovery Process (paradigmxyz#11385)
Merge branch 'main' into fix-feature-propagation
@mattsse mattsse added this pull request to the merge queue Oct 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 19, 2024
@mattsse mattsse added this pull request to the merge queue Oct 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 19, 2024
@liamaharon
Copy link
Contributor Author

Fixed conflicts again :)

onbjerg
onbjerg reviewed Oct 19, 2024
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@onbjerg onbjerg added this pull request to the merge queue Oct 19, 2024
Merged via the queue into paradigmxyz:main with commit cf4a445 Oct 19, 2024
42 checks passed
@liamaharon liamaharon deleted the fix-feature-propagation branch October 19, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg left review comments

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liamaharon @onbjerg @mattsse @DaniPopes