Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of state_change functionality #11878

Merged
merged 9 commits into from
Oct 19, 2024
Merged

Refactor of state_change functionality #11878

merged 9 commits into from
Oct 19, 2024

Conversation

Gerson2102
Copy link
Contributor

This PR is addressing the refactor specified on this issue: #11818

@Gerson2102
Copy link
Contributor Author

Gerson2102 commented Oct 18, 2024 •
edited
Loading

I'm not sure if this is what I had to do. I left a question on the corresponding issue.

mattsse
mattsse requested changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this is the first step, next step is removing the old file and updating the imports of where these functions are used

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-execution Related to the Execution and EVM labels Oct 18, 2024
@Gerson2102
Copy link
Contributor Author

Got it, lmk what you think now.

mattsse
mattsse requested changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good ty,

but I don't want to include the extra ; please undo these

crates/engine/util/src/reorg.rs Show resolved Hide resolved
@Gerson2102
Copy link
Contributor Author

Got it @mattsse, lmk what u think now mate.

mattsse
mattsse approved these changes Oct 19, 2024
View reviewed changes
crates/engine/util/src/reorg.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-eth-api/src/helpers/pending_block.rs Outdated Show resolved Hide resolved
@mattsse mattsse added this pull request to the merge queue Oct 19, 2024
Merged via the queue into paradigmxyz:main with commit a78de20 Oct 19, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gerson2102 @mattsse