Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): Add flags to disable read tx timeout #11856

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(rpc): Add flags to disable read tx timeout #11856

wants to merge 2 commits into from

Conversation

0x00101010
Copy link
Contributor

#11672

Add a flag to disable read tx timeout for long running APIs like debug_executionWitness, eth_getProof, etc

@0x00101010 0x00101010 marked this pull request as ready for review October 17, 2024 21:27
@shekhirin shekhirin added C-enhancement New feature or request A-db Related to the database A-cli Related to the reth CLI labels Oct 18, 2024
shekhirin
shekhirin approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would also appreciate @mattsse or @joshieDo review, I don't have full confidence that these places are the only ones where we need to pass this argument to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-db Related to the database C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x00101010 @shekhirin