Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(engine): rename enveloped associated types to envelope #11812

Merged
merged 2 commits into from
Oct 19, 2024
Merged

chore(engine): rename enveloped associated types to envelope #11812

merged 2 commits into from
Oct 19, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Oct 16, 2024 •
edited by mattsse
Loading

Renames the associated types that are actually envelopes, to be Envelopes

closes #11866

@Rjected Rjected added C-enhancement New feature or request A-consensus Related to the consensus engine labels Oct 16, 2024
@Rjected Rjected mentioned this pull request Oct 18, 2024
Closed
mattsse
mattsse approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

blocking this until the devnet4 pr because rebasing this is easier

blocked by #11865

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Oct 18, 2024
@mattsse mattsse added M-changelog This change should be included in the changelog and removed S-blocked This cannot more forward until something else changes labels Oct 19, 2024
@onbjerg onbjerg added this pull request to the merge queue Oct 19, 2024
Merged via the queue into main with commit 1efa764 Oct 19, 2024
40 checks passed
@onbjerg onbjerg deleted the dan/rename-enveloped-associated-types branch October 19, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename associated types in EngineTypes to reflect that they are envelopes
3 participants
@Rjected @onbjerg @mattsse