Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): define OpTransactionSigned #11433

Draft
wants to merge 119 commits into
base: emhane/sig-op
Choose a base branch
from
Draft

chore(sdk): define OpTransactionSigned #11433

wants to merge 119 commits into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 2, 2024 •
edited
Loading

Based on #11432

Closes #11575

  • Defines new type OpTransactionSigned, that wraps OpSignature (ref chore(op): Def OpSignature #11573) and op_alloy_consensus::OpTypedTransaction
  • Extracts optimism feature gated logic from TransactionSigned impl, into impl SignedTransaction for OpTransactionSigned

@emhane
Define trait reth_node_types::Block
e11c106
@emhane
Define NodePrimitives::Block
c221e4e
@emhane
Add crate reth-ethereum-primitives
d5562b9
@emhane
Add op block primitive
6801cd9
@emhane
Add super traits for reth_node_api::BlockBody
eb92c9c
@emhane
Move reth_primitives::BlockBody impl into trait methods of reth_node_…
7cbed4f 
…api::BlockBody
@emhane
Blanket impl of BlockBody for types that deref to BlockBody type
d2035c6
@emhane
Move reth_primitives::Block impl into trait methods of reth_node_api:…
505e1b6 
…:Block
@emhane
Blanket impl Block for all types that deref to Block type
899c076
@emhane
Separate Block and BlockBody traits into 2 modules
5537a71
@emhane
Make SealedHeader type def generic over header and body
d148202
@emhane
Make BlockWithSenders type def generic over block
d047fde
@emhane
Add super traits for Block
2cbcaff
@emhane
Implement Block for reth_primitives::Block
a8a696a
@emhane
Simplify Block impl for placeholder EthBlock
4576457
@emhane
Simplify Block impl for placeholder OpBlock
ab8254c
@emhane
Impl construction and destruction of Block
9fa9739
@emhane
Move reth_node_api::{Block, BlockBody} into new module reth_primitive…
f228239 
…s::traits
@emhane
Impl BlockBody for reth_primitives::BlockBody
9ab1f08
@emhane
Fix Compact impl for SealedHeader
1f64027
@emhane
Add todo for default impl of BlockBody::size
5d35204
@emhane
Add todo for default impl of Block::size
8a4eea1
@emhane
Impl alloy_consensus::Transaction for TransactionSigned
b9e0e5b
@emhane
Add docs
d29cc05
@emhane
Fix conflicts
df11e22
@emhane
Re-export alloy_consensus::BlockHeader from reth_primitives::traits
117c237
@emhane
Inline Block getters
1d13972
@emhane
Remove redundant Block impls
845a80c
@emhane
Revert remove reth_primitives::Block impl to limit pr scope
2282d4b
@emhane
Revert remove reth_primitives::BlockBody impl to limit pr scope
9b40176
@emhane
Revert reth-optimism-primitives to main
b3d42c1
@emhane
Revert reth-provider to main (no cyclical dep anymore)
9f4260f
@emhane
Revert reth-optimism-node manifest to main
65e7cd7
@emhane
Add Block trait bound to NodePrimitives::Block
aa9ac31
@emhane
Import trait BlockBody into reth-providers
1182338
@emhane
Revert unrelated change
a6fccab
@emhane
Fix docs
6f4d890
@emhane
Remove optimism code from reth-primitives-traits
d5ebe55
@emhane
Remove trait methods from SignedTransaction related to rlp encoding
86eaa11
@emhane
Remove Signature trait from scope
6239a6b
@emhane
Remove trait bound SigneableTransaction off SignedTransaction::Transa…
a232b2a 
…ction
@emhane
Merge branch 'main' into emhane/block-trait
9b07798
@emhane
Revert changes to Makefile
5ea4e68
@emhane
Remove super trait Deref which was used for easy integration into reth
81058c4
@emhane
Merge branch 'emhane/signed-tx-trait' into emhane/op-signed-tx
f21f6bf
@emhane
Fix lint
3b71617
@emhane
Remove trait bound Block on NodePrimitives::Block
300aac1
@emhane
Merge branch 'emhane/block-trait' into emhane/op-signed-tx
7cec1d1
@emhane
Merge branch 'emhane/sig-op' into emhane/op-signed-tx
c750d23
@emhane
Merge branch 'emhane/sig-trait' into emhane/op-signed-tx
e543412
@emhane
Use OpTypedTransaction in OpTransactionSigned
2da6e55
@emhane
Merge branch 'main' into emhane/signed-tx-trait
cbaa53f
@emhane
Merge branch 'emhane/signed-tx-trait' into emhane/op-signed-tx
f469d12
@emhane
Revert Makefile to main
7f43f14
Base automatically changed from emhane/signed-tx-trait to main October 18, 2024 09:57
@emhane emhane changed the base branch from main to emhane/sig-trait October 18, 2024 10:07
@emhane emhane changed the base branch from emhane/sig-trait to emhane/sig-op October 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse