Merge branch 'emhane/sig-op' into emhane/op-signed-tx

paradigmxyz · Oct 18, 2024 · dbf74e1 · dbf74e1
2 parents 0e10ae5 + 735f686
commit dbf74e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/crates/optimism/primitives/Cargo.toml b/crates/optimism/primitives/Cargo.toml
@@ -35,6 +35,9 @@ zstd = { workspace = true, optional = true }
 serde.workspace = true
 arbitrary = { workspace = true, features = ["derive"], optional = true }
 
+# io
+serde.workspace = true
+
 # misc
 derive_more = { workspace = true, features = ["deref", "from", "constructor"] }
 proptest = { workspace = true, optional = true }

diff --git a/crates/primitives-traits/src/signature.rs b/crates/primitives-traits/src/signature.rs
@@ -58,8 +58,6 @@ pub trait Signature: Sized + Send + Sync {
     fn extract_chain_id(v: u64) -> alloy_rlp::Result<(bool, Option<u64>)>;
 }
 
-// todo: add optimism type that wraps Signature, to impl separately for OP to account for system
-// null signature
 impl Signature for alloy_primitives::Signature {
     fn r(&self) -> U256 {
         Self::r(self)