-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add flashbots_*
rpc
#34
Conversation
adds onchain example: stats cannot be inspected for a bundle that has not been seen onchain
run `rm Cargo.lock && cargo build` to fix bad `Cargo.lock` manual merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great already
@@ -418,28 +418,97 @@ pub struct CancelPrivateTransactionRequest { | |||
pub tx_hash: H256, | |||
} | |||
|
|||
// TODO(@optimiz-r): Revisit after <https://github.com/flashbots/flashbots-docs/issues/424> is closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets track this as issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in open new issue in repo linking to this and get rid of TODO line?
spot on, taking care of these immediately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's awesome, tysm!
depends on #33 because of https://github.com/paradigmxyz/mev-share-rs/pull/34/files#diff-3c0917e144af13736e5dd8c32c0ad1497fa59c20361b8454f0064e1a368871aaR102
closes #27