ci: build for macos arm #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
commented
Apr 23, 2024
| @@ -12,18 +12,18 @@ class Reth < Formula | |||
| strategy :github_latest | |||
| end | |||
|
|
|||
| bottle do | |||
There was a problem hiding this comment.
i removed this to have it regen the bottles
DaniPopes
reviewed
Apr 23, 2024
onbjerg
commented
Apr 24, 2024
| sha256 cellar: :any_skip_relocation, x86_64_linux: "7b9c2d91b6ae69b5deace9d2678cec9e843bac772080bdc8191b9a49919d1111" | ||
| end | ||
|
|
||
| depends_on "llvm" => :build |
There was a problem hiding this comment.
i removed this because it was actually silently causing artifacts to go missing for x86 mac due to llvm already being installed by rust, just a diff version - so the linker would get confused 🤷🏻
rkrasiuk
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge
Ref https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
Builds x86 Linux and macOS binaries, as well as macOS ARM binaries in CI. This prevents users from having to build by themselves when using Homebrew unless they explicity want to.
Additionally
asm-keccakunless we're on ARM linuxCloses #41