Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More datasets #64

Merged
merged 10 commits into from
Sep 16, 2023

clean merged code

20d94d1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

More datasets #64

clean merged code
20d94d1
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Sep 16, 2023 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.74.0-nightly (20999de3a 2023-09-15)
  • cargo 1.74.0-nightly (d5336f813 2023-09-14)
  • clippy 0.1.74 (20999de 2023-09-15)

Annotations

Check warning on line 251 in crates/freeze/src/datasets/transaction_addresses.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert_with` to construct default value

warning: use of `or_insert_with` to construct default value
   --> crates/freeze/src/datasets/transaction_addresses.rs:251:43
    |
251 |                 logs_by_tx.entry(tx_hash).or_insert_with(Vec::new).push(log);
    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 360 in crates/freeze/src/datasets/logs.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert` to construct default value

warning: use of `or_insert` to construct default value
   --> crates/freeze/src/datasets/logs.rs:360:64
    |
360 | ...                   let tokens = map.entry(param.name).or_insert(Vec::new());
    |                                                          ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 251 in crates/freeze/src/datasets/logs.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert` to construct default value

warning: use of `or_insert` to construct default value
   --> crates/freeze/src/datasets/logs.rs:251:42
    |
251 |                 self.event_cols.entry(k).or_insert(Vec::new()).extend(v);
    |                                          ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `#[warn(clippy::unwrap_or_default)]` on by default

Check warning on line 190 in crates/freeze/src/datasets/erc20_metadata.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u32` -> `u32`)

warning: casting to the same type is unnecessary (`u32` -> `u32`)
   --> crates/freeze/src/datasets/erc20_metadata.rs:190:36
    |
190 |             self.block_number.push(block_number as u32);
    |                                    ^^^^^^^^^^^^^^^^^^^ help: try: `block_number`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 105 in crates/freeze/src/types/queries.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `to_address_chunks` is never used

warning: method `to_address_chunks` is never used
   --> crates/freeze/src/types/queries.rs:105:19
    |
90  | impl RowFilter {
    | -------------- method in this implementation
...
105 |     pub(crate) fn to_address_chunks(&self) -> Result<Vec<AddressChunk>, CollectError> {
    |                   ^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default