Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(u256) hex output check for u256 series generation. #57

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix(u256) hex output check for u256 series generation. #57

merged 1 commit into from
Sep 5, 2023

Conversation

kskalski
Copy link
Contributor

@kskalski kskalski commented Sep 5, 2023

Motivation

Fixes #55

Solution

Since column_type returns U256 now, the check for hex should be against the global column encoding instead of column type.

PR Checklist

  • Added Tests
  • Added Documentation
  • [ none ] Breaking changes

@kskalski kskalski mentioned this pull request Sep 5, 2023
Closed
@sslivkoff sslivkoff merged commit 54a47f4 into paradigmxyz:main Sep 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV Output Broken
2 participants
@kskalski @sslivkoff