remove name() from Dataset trait (#84)

paradigmxyz · Oct 20, 2023 · a4747a4 · a4747a4
1 parent 4edc589
commit a4747a4
Show file tree

Hide file tree

Showing 30 changed files with 0 additions and 120 deletions.
diff --git a/crates/freeze/src/datasets/address_appearances.rs b/crates/freeze/src/datasets/address_appearances.rs
@@ -17,10 +17,6 @@ pub struct AddressAppearances {
 
 #[async_trait::async_trait]
 impl Dataset for AddressAppearances {
-    fn name() -> &'static str {
-        "transaction_addresses"
-    }
-
     fn default_sort() -> Vec<String> {
         vec![
             "block_number".to_string(),

diff --git a/crates/freeze/src/datasets/balance_diffs.rs b/crates/freeze/src/datasets/balance_diffs.rs
@@ -22,10 +22,6 @@ type Result<T> = ::core::result::Result<T, CollectError>;
 
 #[async_trait::async_trait]
 impl Dataset for BalanceDiffs {
-    fn name() -> &'static str {
-        "balance_diffs"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/balances.rs b/crates/freeze/src/datasets/balances.rs
@@ -16,10 +16,6 @@ pub struct Balances {
 
 #[async_trait::async_trait]
 impl Dataset for Balances {
-    fn name() -> &'static str {
-        "balances"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "address".to_string()]
     }

diff --git a/crates/freeze/src/datasets/blocks.rs b/crates/freeze/src/datasets/blocks.rs
@@ -27,10 +27,6 @@ pub struct Blocks {
 
 #[async_trait::async_trait]
 impl Dataset for Blocks {
-    fn name() -> &'static str {
-        "blocks"
-    }
-
     fn default_columns() -> Option<Vec<&'static str>> {
         Some(vec![
             "block_number",

diff --git a/crates/freeze/src/datasets/code_diffs.rs b/crates/freeze/src/datasets/code_diffs.rs
@@ -19,10 +19,6 @@ pub struct CodeDiffs {
 
 #[async_trait::async_trait]
 impl Dataset for CodeDiffs {
-    fn name() -> &'static str {
-        "code_diffs"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/codes.rs b/crates/freeze/src/datasets/codes.rs
@@ -16,10 +16,6 @@ pub struct Codes {
 
 #[async_trait::async_trait]
 impl Dataset for Codes {
-    fn name() -> &'static str {
-        "codes"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "address".to_string()]
     }

diff --git a/crates/freeze/src/datasets/contracts.rs b/crates/freeze/src/datasets/contracts.rs
@@ -25,10 +25,6 @@ pub struct Contracts {
 
 #[async_trait::async_trait]
 impl Dataset for Contracts {
-    fn name() -> &'static str {
-        "contracts"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "create_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/erc20_balances.rs b/crates/freeze/src/datasets/erc20_balances.rs
@@ -17,10 +17,6 @@ pub struct Erc20Balances {
 
 #[async_trait::async_trait]
 impl Dataset for Erc20Balances {
-    fn name() -> &'static str {
-        "erc20_balances"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string()]
     }

diff --git a/crates/freeze/src/datasets/erc20_metadata.rs b/crates/freeze/src/datasets/erc20_metadata.rs
@@ -17,10 +17,6 @@ pub struct Erc20Metadata {
 
 #[async_trait::async_trait]
 impl Dataset for Erc20Metadata {
-    fn name() -> &'static str {
-        "erc20_metadata"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["symbol".to_string(), "block_number".to_string()]
     }

diff --git a/crates/freeze/src/datasets/erc20_supplies.rs b/crates/freeze/src/datasets/erc20_supplies.rs
@@ -16,10 +16,6 @@ pub struct Erc20Supplies {
 
 #[async_trait::async_trait]
 impl Dataset for Erc20Supplies {
-    fn name() -> &'static str {
-        "erc20_supplies"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["erc20".to_string(), "block_number".to_string()]
     }

diff --git a/crates/freeze/src/datasets/erc20_transfers.rs b/crates/freeze/src/datasets/erc20_transfers.rs
@@ -21,10 +21,6 @@ pub struct Erc20Transfers {
 
 #[async_trait::async_trait]
 impl Dataset for Erc20Transfers {
-    fn name() -> &'static str {
-        "erc20_transfers"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "log_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/erc721_metadata.rs b/crates/freeze/src/datasets/erc721_metadata.rs
@@ -16,10 +16,6 @@ pub struct Erc721Metadata {
 }
 
 impl Dataset for Erc721Metadata {
-    fn name() -> &'static str {
-        "erc721_metadata"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["symbol".to_string(), "block_number".to_string()]
     }

diff --git a/crates/freeze/src/datasets/erc721_transfers.rs b/crates/freeze/src/datasets/erc721_transfers.rs
@@ -21,10 +21,6 @@ pub struct Erc721Transfers {
 
 #[async_trait::async_trait]
 impl Dataset for Erc721Transfers {
-    fn name() -> &'static str {
-        "erc721_transfers"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "log_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/eth_calls.rs b/crates/freeze/src/datasets/eth_calls.rs
@@ -19,10 +19,6 @@ pub struct EthCalls {
 
 #[async_trait::async_trait]
 impl Dataset for EthCalls {
-    fn name() -> &'static str {
-        "eth_calls"
-    }
-
     fn default_columns() -> Option<Vec<&'static str>> {
         Some(vec!["block_number", "contract_address", "call_data", "output_data", "chain_id"])
     }

diff --git a/crates/freeze/src/datasets/geth_balance_diffs.rs b/crates/freeze/src/datasets/geth_balance_diffs.rs
@@ -21,10 +21,6 @@ type Result<T> = ::core::result::Result<T, CollectError>;
 
 #[async_trait::async_trait]
 impl Dataset for GethBalanceDiffs {
-    fn name() -> &'static str {
-        "balance_diffs"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/geth_code_diffs.rs b/crates/freeze/src/datasets/geth_code_diffs.rs
@@ -20,10 +20,6 @@ type Result<T> = ::core::result::Result<T, CollectError>;
 
 #[async_trait::async_trait]
 impl Dataset for GethCodeDiffs {
-    fn name() -> &'static str {
-        "code_diffs"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/geth_nonce_diffs.rs b/crates/freeze/src/datasets/geth_nonce_diffs.rs
@@ -20,10 +20,6 @@ type Result<T> = ::core::result::Result<T, CollectError>;
 
 #[async_trait::async_trait]
 impl Dataset for GethNonceDiffs {
-    fn name() -> &'static str {
-        "nonce_diffs"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/geth_storage_diffs.rs b/crates/freeze/src/datasets/geth_storage_diffs.rs
@@ -17,12 +17,7 @@ pub struct GethStorageDiffs {
     pub(crate) chain_id: Vec<u64>,
 }
 
-#[async_trait::async_trait]
 impl Dataset for GethStorageDiffs {
-    fn name() -> &'static str {
-        "geth_storage_diffs"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/geth_traces.rs b/crates/freeze/src/datasets/geth_traces.rs
@@ -28,10 +28,6 @@ type Result<T> = ::core::result::Result<T, CollectError>;
 
 #[async_trait::async_trait]
 impl Dataset for GethTraces {
-    fn name() -> &'static str {
-        "geth_traces"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/logs.rs b/crates/freeze/src/datasets/logs.rs
@@ -25,10 +25,6 @@ pub struct Logs {
 
 #[async_trait::async_trait]
 impl Dataset for Logs {
-    fn name() -> &'static str {
-        "logs"
-    }
-
     fn aliases() -> Vec<&'static str> {
         vec!["events"]
     }

diff --git a/crates/freeze/src/datasets/native_transfers.rs b/crates/freeze/src/datasets/native_transfers.rs
@@ -20,10 +20,6 @@ pub struct NativeTransfers {
 
 #[async_trait::async_trait]
 impl Dataset for NativeTransfers {
-    fn name() -> &'static str {
-        "native_transfers"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transfer_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/nonce_diffs.rs b/crates/freeze/src/datasets/nonce_diffs.rs
@@ -19,10 +19,6 @@ pub struct NonceDiffs {
 
 #[async_trait::async_trait]
 impl Dataset for NonceDiffs {
-    fn name() -> &'static str {
-        "nonce_diffs"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/nonces.rs b/crates/freeze/src/datasets/nonces.rs
@@ -16,10 +16,6 @@ pub struct Nonces {
 
 #[async_trait::async_trait]
 impl Dataset for Nonces {
-    fn name() -> &'static str {
-        "nonces"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "address".to_string()]
     }

diff --git a/crates/freeze/src/datasets/slots.rs b/crates/freeze/src/datasets/slots.rs
@@ -17,10 +17,6 @@ pub struct Slots {
 
 #[async_trait::async_trait]
 impl Dataset for Slots {
-    fn name() -> &'static str {
-        "slots"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "address".to_string(), "slot".to_string()]
     }

diff --git a/crates/freeze/src/datasets/storage_diffs.rs b/crates/freeze/src/datasets/storage_diffs.rs
@@ -20,10 +20,6 @@ pub struct StorageDiffs {
 
 #[async_trait::async_trait]
 impl Dataset for StorageDiffs {
-    fn name() -> &'static str {
-        "storage_diffs"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/trace_calls.rs b/crates/freeze/src/datasets/trace_calls.rs
@@ -33,10 +33,6 @@ pub struct TraceCalls {
 }
 
 impl Dataset for TraceCalls {
-    fn name() -> &'static str {
-        "trace_calls"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/traces.rs b/crates/freeze/src/datasets/traces.rs
@@ -33,10 +33,6 @@ pub struct Traces {
 
 #[async_trait::async_trait]
 impl Dataset for Traces {
-    fn name() -> &'static str {
-        "traces"
-    }
-
     fn default_sort() -> Vec<String> {
         vec!["block_number".to_string(), "transaction_index".to_string()]
     }

diff --git a/crates/freeze/src/datasets/transactions.rs b/crates/freeze/src/datasets/transactions.rs
@@ -27,10 +27,6 @@ pub struct Transactions {
 
 #[async_trait::async_trait]
 impl Dataset for Transactions {
-    fn name() -> &'static str {
-        "transactions"
-    }
-
     fn aliases() -> Vec<&'static str> {
         vec!["txs"]
     }

diff --git a/crates/freeze/src/datasets/vm_traces.rs b/crates/freeze/src/datasets/vm_traces.rs
@@ -25,10 +25,6 @@ pub struct VmTraces {
 
 #[async_trait::async_trait]
 impl Dataset for VmTraces {
-    fn name() -> &'static str {
-        "vm_traces"
-    }
-
     fn aliases() -> Vec<&'static str> {
         vec!["opcode_traces"]
     }

diff --git a/crates/freeze/src/types/columns.rs b/crates/freeze/src/types/columns.rs
@@ -51,9 +51,6 @@ pub trait ToDataFrames: Sized {
 
 /// Dataset manages collection and management of a particular datatype
 pub trait Dataset: Sync + Send {
-    /// name of Dataset
-    fn name() -> &'static str;
-
     /// alias of Dataset
     fn aliases() -> Vec<&'static str> {
         vec![]