fix(path-order): don't trash previous parameter names #1171
Annotations
17 errors and 20 warnings
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/lib.rs#L74
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/lib.rs:74:35
|
74 | op_map.methods.extend(operations.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `operations`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
use of `or_insert_with` to construct default value:
plugins/actix-web/src/lib.rs#L73
error: use of `or_insert_with` to construct default value
--> plugins/actix-web/src/lib.rs:73:18
|
73 | .or_insert_with(Default::default);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/app.rs#L450
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/app.rs:450:32
|
450 | api.definitions.extend(factory.definitions().into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `factory.definitions()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/web.rs#L744
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/web.rs:744:33
|
744 | self.definitions.extend(factory.definitions().into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `factory.definitions()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/web.rs#L732
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/web.rs:732:33
|
732 | self.definitions.extend(w.definitions().into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `w.definitions()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/web.rs#L723
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/web.rs:723:35
|
723 | op_map.methods.extend(item.methods.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `item.methods`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
use of `or_insert_with` to construct default value:
plugins/actix-web/src/web.rs#L722
error: use of `or_insert_with` to construct default value
--> plugins/actix-web/src/web.rs:722:42
|
722 | let op_map = map.entry(path).or_insert_with(Default::default);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/web.rs#L492
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/web.rs:492:35
|
492 | op_map.methods.extend(item.methods.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `item.methods`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
use of `or_insert_with` to construct default value:
plugins/actix-web/src/web.rs#L491
error: use of `or_insert_with` to construct default value
--> plugins/actix-web/src/web.rs:491:42
|
491 | let op_map = map.entry(path).or_insert_with(Default::default);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D clippy::all`
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/web.rs#L447
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/web.rs:447:33
|
447 | self.definitions.extend(factory.definitions().into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `factory.definitions()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/web.rs#L251
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/web.rs:251:37
|
251 | self.definitions.extend(U::definitions().into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `U::definitions()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/web.rs#L125
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/web.rs:125:33
|
125 | self.definitions.extend(w.definitions.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `w.definitions`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
plugins/actix-web/src/web.rs#L124
error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> plugins/actix-web/src/web.rs:124:32
|
124 | self.operations.extend(w.operations.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `w.operations`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/d12c6e947ceacf3b22c154caf9532b390d8dc88a/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D clippy::all`
|
unneeded sub `cfg` when there is only one condition:
plugins/actix-web/src/app.rs#L15
error: unneeded sub `cfg` when there is only one condition
--> plugins/actix-web/src/app.rs:15:7
|
15 | #[cfg(any(feature = "swagger-ui"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "swagger-ui"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
= note: `-D clippy::non-minimal-cfg` implied by `-D clippy::all`
|
clippy (true, nightly, -A clippy::uninlined-format-args -A clippy::derivable-impls)
Clippy had exited with the 101 exit code
|
unneeded sub `cfg` when there is only one condition:
plugins/actix-web/src/app.rs#L15
error: unneeded sub `cfg` when there is only one condition
--> plugins/actix-web/src/app.rs:15:7
|
15 | #[cfg(any(feature = "swagger-ui"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "swagger-ui"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
= note: `-D clippy::non-minimal-cfg` implied by `-D clippy::all`
|
clippy (false)
Clippy had exited with the 101 exit code
|
rustfmt (stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
rustfmt (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt (stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt (nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
rustfmt (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt (nightly)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (true, nightly, -A clippy::uninlined-format-args -A clippy::derivable-impls)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy (true, nightly, -A clippy::uninlined-format-args -A clippy::derivable-impls)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (true, nightly, -A clippy::uninlined-format-args -A clippy::derivable-impls)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (true, nightly, -A clippy::uninlined-format-args -A clippy::derivable-impls)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (true, nightly, -A clippy::uninlined-format-args -A clippy::derivable-impls)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy (false)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (false)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (false)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy (false)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|