Support trailing global flags in the native parser. #21480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy parser supports having global flags at the end of the command-line invocation, after all specs. Now the native parser supports this too.
benjyw
added
the
release-notes:not-required
tgolsson
approved these changes
Oct 3, 2024
WorkerPants
pushed a commit
that referenced
this pull request
Oct 3, 2024
The legacy parser supports having global flags at the end of the command-line invocation, after all specs. Now the native parser supports this too. Fixes #21478
WorkerPants
pushed a commit
that referenced
this pull request
Oct 3, 2024
The legacy parser supports having global flags at the end of the command-line invocation, after all specs. Now the native parser supports this too. Fixes #21478
benjyw
added a commit
that referenced
this pull request
Oct 3, 2024
…21480) (#21485) The legacy parser supports having global flags at the end of the command-line invocation, after all specs. Now the native parser supports this too. Fixes #21478 Co-authored-by: Benjy Weinberger <[email protected]>
benjyw
added a commit
that referenced
this pull request
Oct 3, 2024
…21480) (#21486) The legacy parser supports having global flags at the end of the command-line invocation, after all specs. Now the native parser supports this too. Fixes #21478 Co-authored-by: Benjy Weinberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy parser supports having global flags at the end of
the command-line invocation, after all specs.
Now the native parser supports this too.
Fixes #21478