Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MkdirBinary in coursier fetch wrapper script #21463

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

grihabor
Copy link
Contributor

@grihabor grihabor commented Oct 1, 2024

grihabor added a commit to grihabor/pants-nix that referenced this pull request Oct 1, 2024
grihabor added a commit to grihabor/pants-nix that referenced this pull request Oct 1, 2024
@tgolsson tgolsson added backend: JVM JVM backend-related issues category:bugfix Bug fixes for released features labels Oct 2, 2024
Copy link
Contributor

@tgolsson tgolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems innocuous. I assume you've tested this with Nix, and tests seems to pass.

@grihabor
Copy link
Contributor Author

grihabor commented Oct 3, 2024

Yep, thanks

@grihabor
Copy link
Contributor Author

grihabor commented Oct 3, 2024

@tgolsson Shall we merge it?

@tgolsson tgolsson merged commit 0f78dd5 into pantsbuild:main Oct 4, 2024
25 checks passed
@grihabor grihabor deleted the fix-coursier-mkdir branch October 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: JVM JVM backend-related issues category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coursier_fetch_wrapper_script: /bin/mkdir: No such file or directory on Nixos
2 participants