Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Bump rubocop-rails from 2.17.2 to 2.19.1 #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 17, 2023

Bumps rubocop-rails from 2.17.2 to 2.19.1.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.19.1

Bug fixes

  • #979: Fix an error for Rails/ThreeStateBooleanColumn when using t.boolean in drop_table. (@​koic)

RuboCop Rails 2.19.0

New features

Bug fixes

  • #934: Fix a false negative for Rails/Output when print methods without arguments. (@​koic)
  • #99: Fix a false positive for Rails/HttpPositionalArguments when using include Rack::Test::Methods. (@​koic)
  • #501: Fix a false positive for Rails/OutputSafety when using html_safe for I18n methods. (@​koic)
  • #860: Fix a false positive for Rails/Pluck when using regexp literal key for String#[]. (@​koic)
  • #938: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not.lt(condition) as a Mongoid API'. (@​koic)
  • #941: Remove redundant config for Style/InverseMethods. (@​koic)

Changes

  • #299: Add autocorrection for Rails/ReflectionClassName. (@​tejasbubane)
  • #34: Allow CreateTableWithTimestamps when using id: false and not include timestamps. (@​koic)
  • #694: Mark Rails/FindEach as unsafe. (@​koic)
  • #940: Mark Rails/ResponseParsedBody as unsafe. (@​koic)

RuboCop Rails 2.17.4

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. (@​koic)
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. (@​gurix)
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. (@​ydah)
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. (@​koic)
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. ([@​etiennebarrie][])
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. (@​fatkodima)

Changes

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.19.1 (2023-04-16)

Bug fixes

  • #979: Fix an error for Rails/ThreeStateBooleanColumn when using t.boolean in drop_table. ([@​koic][])

2.19.0 (2023-04-07)

New features

Bug fixes

  • #934: Fix a false negative for Rails/Output when print methods without arguments. ([@​koic][])
  • #99: Fix a false positive for Rails/HttpPositionalArguments when using include Rack::Test::Methods. ([@​koic][])
  • #501: Fix a false positive for Rails/OutputSafety when using html_safe for I18n methods. ([@​koic][])
  • #860: Fix a false positive for Rails/Pluck when using regexp literal key for String#[]. ([@​koic][])
  • #938: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not.lt(condition) as a Mongoid API'. ([@​koic][])
  • #941: Remove redundant config for Style/InverseMethods. ([@​koic][])

Changes

  • #299: Add autocorrection for Rails/ReflectionClassName. ([@​tejasbubane][])
  • #34: Allow CreateTableWithTimestamps when using id: false and not include timestamps. ([@​koic][])
  • #694: Mark Rails/FindEach as unsafe. ([@​koic][])
  • #940: Mark Rails/ResponseParsedBody as unsafe. ([@​koic][])

2.18.0 (2023-02-25)

New features

Bug fixes

  • #824: Fix a false negative for Rails/ActionControllerTestCase when the class is namespaced. ([@​vlad-pisanov][])
  • #909: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash before redirect_to in if branch. ([@​koic][])
  • #898: Fix a false positive for Rails/ActiveRecordAliases when arguments of update_attributes is empty. ([@​koic][])
  • #920: Fix an error for Rails/NegateInclude when there is no receiver. ([@​fatkodima][])
  • #931: Fix error in Rails/Presence when ternary operators are used in multiple lines. ([@​r7kamura][])
  • #687: Fix Rails/HasManyOrHasOneDependent to correctly handle association methods with receiver. ([@​fatkodima][])
  • #929: Prevent Rails/SquishedSQLHeredocs applying when single-line comments are present. ([@​john-h-k][])
  • #887: Fix a false positive for Rails/NotNullColumn when adding a :virtual column. ([@​fatkodima][])
  • #918: Fix Rails/FreezeTime running against Rails < 5.2 apps. ([@​DRBragg][])
  • #895: Fix Rails/UnusedIgnoredColumns not recognizing columns added via +=. ([@​lucthev][])

Changes

... (truncated)

Commits
  • f10f7e0 Cut 2.19.1
  • 1e03d84 Update Changelog
  • 9286f9d Add the style guide URL for Rails/WhereNotWithMultipleConditions
  • a889677 Merge pull request #983 from koic/fix_an_error_for_rails_three_state_boolean
  • 96821da Merge pull request #977 from tmaier/generator-2
  • d098903 [Fix #979] Fix an error for Rails/ThreeStateBooleanColumn
  • f5c9e30 Update documentation to fix Rubocop errors in 'rails generate' command
  • 73fd423 Use RuboCop Performance 1.17
  • b06cb7c Remove legacy docs
  • d1579f2 Switch back docs version to master
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.17.2 to 2.19.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.17.2...v2.19.1)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file Needs QA labels Apr 17, 2023
@dependabot dependabot bot requested a review from a team April 17, 2023 05:00
@tfollo
Copy link

tfollo commented Apr 20, 2023

We will pause on this until the work to split the panolint repo into panolint-ruby and panolint-rails is complete. Ticket with the status of that work: https://panoramaed.atlassian.net/browse/ACON-18

@panorama-bot-r panorama-bot-r requested review from a team and removed request for a team May 3, 2023 17:42
@cyrorama
Copy link

cyrorama commented Jun 1, 2023

I added a commit to prevent Dependabot from re-creating this PR.

Rubocop updates are part of the Dependabot backlog, as they require large amounts of work to get through.

My comment should be removed once this is worked on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file Needs QA squad-backlogged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants