Add safety check #28
Merged
Add safety check #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding `get_safe_reading` that checks the thresholds. * Adding `status` and `is_safe` properties. * Remove `enqueue` option and always save some readings.
* Adding `get_safe_reading` that checks the thresholds. * Adding `status` and `is_safe` properties. * Remove `enqueue` option and always save some readings.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 57.83% 61.98% +4.14%
==========================================
Files 6 6
Lines 268 313 +45
Branches 30 45 +15
==========================================
+ Hits 155 194 +39
- Misses 110 112 +2
- Partials 3 7 +4
☔ View full report in Codecov by Sentry. |
* More tests. * Small readme fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_safe_readingthat checks the thresholds.statusandis_safeproperties.enqueueoption and always save some readings.