Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bisque parking and home issues #918

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Oct 23, 2019

This should address #915 and AstroHuntsman/huntsman-pocs#102 but needs hardware testing.

@wtgee wtgee changed the title Bisque parking 102 915 Bisque parking and home issues Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #918 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #918      +/-   ##
===========================================
- Coverage    83.12%   83.09%   -0.03%     
===========================================
  Files           80       80              
  Lines         6294     6295       +1     
  Branches       831      831              
===========================================
- Hits          5232     5231       -1     
- Misses         846      847       +1     
- Partials       216      217       +1
Impacted Files Coverage Δ
pocs/serial_handlers/protocol_arduinosimulator.py 99.2% <0%> (-0.4%) ⬇️
pocs/mount/mount.py 65.11% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631b812...98665c3. Read the comment docs.

Copy link
Collaborator

@AnthonyHorton AnthonyHorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it makes sense...

@wtgee wtgee merged commit 1cf3ffe into panoptes:develop Oct 24, 2019
@wtgee wtgee deleted the bisque-parking-102-915 branch October 24, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants