Allow arbitrary FITS headers #1015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, based this off |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for adding custom FITS headers from the
headersparam oftake_observation. Follow up from #1009 .Description
The
take_observationfunction accepts aheadersdict. Previously the keywords in this dict that matched a predefined (and hard-coded, see #1014) pattern would be included in the final FITS image.This PR essentially copies everything from
headersinto the header. It will still parse the pre-defined list of headers (e.g.field_name->FIELD).Keywords in
headersthat don't conform to the FITS standard will be added asHIERARCH(see the [set(https://docs.astropy.org/en/stable/io/fits/api/headers.html#astropy.io.fits.Header.set)] method for headers; sadly it's not documented that I found, but it's in the source).Related Issue
Closes #1013
From #1009
How Has This Been Tested?
Added a new test specifically for the arbitrary headers.
Types of changes