Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POCS.park() doesn't park bisque mount #915

Open
AnthonyHorton opened this issue Oct 22, 2019 · 3 comments
Open

POCS.park() doesn't park bisque mount #915

AnthonyHorton opened this issue Oct 22, 2019 · 3 comments
Milestone

Comments

@AnthonyHorton
Copy link
Collaborator

Describe the bug
When calling POCS.park() with Huntsman (which has a bisque type Mount) there is an unhandled TheSkyXTimeout error immediately after sending the command to home the mount, which results in the subsequent mount park command not being sent. Consequently the mount ends up being left at the home position instead of the park position. Seems like POCS is not waiting for the home mount command to complete?

To Reproduce
Steps to reproduce the behavior:

  1. Create a POCS instance with an Observatory that has a Mount of bisque type.
  2. Start the POCS instance running.
  3. Invoke POCS.park().

Expected behaviour
The mount first moves to the home position (why?), then to the park position.

Actual behaviour
Mounts starts moving to the home position, there is a TheSkyXTimeout error, the mount does not park.

@wtgee
Copy link
Member

wtgee commented Oct 22, 2019

This probably just needs to implement the blocking=True option created in #887. The default was left to False so there wouldn't be any unexpected changes from what currently existed.

Note that the parameter is currently being passed, just need to build in some kind of check and timeout.

https://github.com/panoptes/POCS/blob/develop/pocs/mount/bisque.py#L206-L223

@wtgee
Copy link
Member

wtgee commented Oct 23, 2019

Related: AstroHuntsman/huntsman-pocs#102

@wtgee
Copy link
Member

wtgee commented Oct 23, 2019

Not recreating this either. Seems like with #916 and #917 there was something causing that TheSkyXTimeout to occur, which was making each of the commands fail. This was also before we had the odd TSX communication errors. Will leave open for now until we find out more info.

@wtgee wtgee added this to the V1.0 milestone Feb 17, 2020
@wtgee wtgee modified the milestones: V1.0, v2.0 Jan 20, 2022
@wtgee wtgee modified the milestones: v2.0, v0.9.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants