This repository has been archived by the owner on Jan 4, 2018. It is now read-only.
Make toggle_relay more robust, esp. when working with the modification #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by James Synge to the Arduino code for parsing serial input.
|
Unfortunately there is no real tie-in with the simulators for this so would be hard to test without actually hooking it up. Code LGTM though. |
|
@jamessynge Do you want to put this in POCS post-consolidation? I've already got an open PR for the consolidation: panoptes/POCS#106 |
|
I suppose what might be best for safety on PAN00[16], is to have different primary development branches for post-merge and pre-merge repo(s), so that those units can keep working with the stable code while we get post-merge POCS ready. How does that sound? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by James Synge to the Arduino code for parsing serial input.
Not yet tested. Is there a way to run peas_shell this with simulated hardware?