ci: replace macos-latest with macos-12 for go1.13 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #326 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 11 11
Lines 759 759
=======================================
Hits 693 693
Misses 45 45
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
panjf2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
There is an uncanny issue arising when downloading go modules on macOS 13 for Go1.13. So we use macOS 12 for now.
Starting macOS 14 GitHub Actions runners are arm-based but Go didn't support arm64 until 1.16, which will result in some CI failure after the
macos-latesthad been migrated from macOS 12 to 14. Thus, we must replace the macOS 14 runner with the macOS 13 runner for Go 1.13.Check out actions/runner-images#9741 for more details.