Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address several documentation warnings #843

Merged

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 20, 2023

Description

This PR fixes a few issues with dependency conflicts that were causing the docs to fail to build, as well as address a few calls directly to now-obsolete functions.

There remains around 230 documentation build warnings, but nothing that breaks the build itself. Addressing all of these could take time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improved Documentation

How Has This Been Tested?

Tested via ReadTheDocs

Checklist (while developing)

  • I have updated the sphinx documentation, if necessary.
  • CHANGELOG is updated with reference to this PR.

References

See also: #844

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc6e33a) 91.72% compared to head (a5cb6d5) 91.72%.

Additional details and impacted files
@@                                Coverage Diff                                 @@
##           dependabot/github_actions/actions/github-script-7     #843   +/-   ##
==================================================================================
  Coverage                                              91.72%   91.72%           
==================================================================================
  Files                                                     59       59           
  Lines                                                   6246     6246           
==================================================================================
  Hits                                                    5729     5729           
  Misses                                                   517      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zeitsperre Zeitsperre marked this pull request as ready for review November 20, 2023 20:34
@aaronspring aaronspring merged commit bb76ecb into dependabot/github_actions/actions/github-script-7 Nov 20, 2023
25 checks passed
@aaronspring aaronspring deleted the doc-adjustments branch November 20, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants